yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Refactor hover previews to reduce false positives (#6091)

Browse Source
This commit is contained in:
Tom Moor
2023-10-29 18:31:12 -04:00
committed by GitHub
parent 90bc60d4cf
commit 6b13a32234
9 changed files with 265 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
shared/editor/marks/Link.tsx
View File

@@ -88,7 +88,7 @@ export default class Link extends Mark {
{
title: node.attrs.title,
href: sanitizeUrl(node.attrs.href),
class: "text-link",
class: "use-hover-preview",
rel: "noopener noreferrer nofollow",
},
0,
@@ -203,20 +203,6 @@ export default class Link extends Mark {
props: {
decorations: (state: EditorState) => plugin.getState(state),
handleDOMEvents: {
mouseover: (view: EditorView, event: MouseEvent) => {
const target = (event.target as HTMLElement)?.closest("a");
if (
target instanceof HTMLAnchorElement &&
target.className.includes("text-link") &&
this.editor.elementRef.current?.contains(target) &&
(!view.editable || (view.editable && !view.hasFocus()))
) {
if (this.options.onHoverLink) {
return this.options.onHoverLink(target);
}
}
return false;
},
mousedown: (view: EditorView, event: MouseEvent) => {
const target = (event.target as HTMLElement)?.closest("a");
if (!(target instanceof HTMLAnchorElement) || event.button !== 0) {