fix: Cleanup relationships when user is deleted (#6343)

* fix: Cleanup relationships when user is deleted

* Update tests

* Update User.test.ts

server/models/User.test.ts

@@ -1,7 +1,6 @@
 import { faker } from "@faker-js/faker";
 import { CollectionPermission } from "@shared/types";
 import { buildUser, buildTeam, buildCollection } from "@server/test/factories";
-import UserAuthentication from "./UserAuthentication";
 import UserPermission from "./UserPermission";
 
 beforeAll(() => {
@@ -36,23 +35,11 @@ describe("user model", () => {
   });
 
   describe("destroy", () => {
-    it("should delete user authentications", async () => {
+    it("should clear PII", async () => {
       const user = await buildUser();
-      expect(
-        await UserAuthentication.count({
-          where: {
-            userId: user.id,
-          },
-        })
-      ).toBe(1);
       await user.destroy();
-      expect(
-        await UserAuthentication.count({
-          where: {
-            userId: user.id,
-          },
-        })
-      ).toBe(0);
+      expect(user.email).toBe(null);
+      expect(user.name).toBe("Unknown");
     });
   });
 

server/models/User.ts

@@ -43,11 +43,9 @@ import env from "@server/env";
 import DeleteAttachmentTask from "@server/queues/tasks/DeleteAttachmentTask";
 import parseAttachmentIds from "@server/utils/parseAttachmentIds";
 import { ValidationError } from "../errors";
-import ApiKey from "./ApiKey";
 import Attachment from "./Attachment";
 import AuthenticationProvider from "./AuthenticationProvider";
 import Collection from "./Collection";
-import Star from "./Star";
 import Team from "./Team";
 import UserAuthentication from "./UserAuthentication";
 import UserPermission from "./UserPermission";
@@ -586,24 +584,6 @@ class User extends ParanoidModel {
     model: User,
     options: { transaction: Transaction }
   ) => {
-    await ApiKey.destroy({
-      where: {
-        userId: model.id,
-      },
-      transaction: options.transaction,
-    });
-    await Star.destroy({
-      where: {
-        userId: model.id,
-      },
-      transaction: options.transaction,
-    });
-    await UserAuthentication.destroy({
-      where: {
-        userId: model.id,
-      },
-      transaction: options.transaction,
-    });
     model.email = null;
     model.name = "Unknown";
     model.avatarUrl = null;