fix: useMousePosition can set state after component unmounted

fix: Clicking item in SubMenu does not close parent menu
2022-12-31 10:34:11 -05:00
parent e70f1ed84c
commit 575f70a9e2
5 changed files with 41 additions and 31 deletions
--- a/app/components/ContextMenu/MenuItem.tsx
+++ b/app/components/ContextMenu/MenuItem.tsx
@@ -41,13 +41,10 @@ const MenuItem = (
    (ev) => {
      if (onClick) {
        ev.preventDefault();
-        ev.stopPropagation();
        onClick(ev);
      }

-      if (hide) {
-        hide();
-      }
+      hide?.();
    },
    [onClick, hide]
  );