yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Moving an image to empty space results in endless upload (#3799)

Browse Source 
* fix: Error dragging images below doc, types

* fix: Handle html/text content dropped into padding

* refactor, docs
This commit is contained in:
Tom Moor
2022-07-17 11:31:55 +01:00
committed by GitHub
parent dee87f15af
commit 4af69b2758
8 changed files with 116 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/menus/CollectionMenu.tsx
View File

@@ -16,7 +16,7 @@ import { useTranslation } from "react-i18next";
import { useHistory } from "react-router-dom";
import { useMenuState, MenuButton, MenuButtonHTMLProps } from "reakit/Menu";
import { VisuallyHidden } from "reakit/VisuallyHidden";
import getDataTransferFiles from "@shared/utils/getDataTransferFiles";
import { getEventFiles } from "@shared/utils/files";
import Collection from "~/models/Collection";
import CollectionEdit from "~/scenes/CollectionEdit";
import CollectionExport from "~/scenes/CollectionExport";
@@ -117,8 +117,8 @@ function CollectionMenu({
);
const handleFilePicked = React.useCallback(
async (ev: React.FormEvent<HTMLInputElement>) => {
const files = getDataTransferFiles(ev);
async (ev: React.ChangeEvent<HTMLInputElement>) => {
const files = getEventFiles(ev);
// Because this is the onChange handler it's possible for the change to be
// from previously selecting a file to not selecting a file – aka empty