Separate status and role filters in member management

app/scenes/Settings/Members.tsx

@@ -22,6 +22,7 @@ import usePolicy from "~/hooks/usePolicy";
 import useQuery from "~/hooks/useQuery";
 import useStores from "~/hooks/useStores";
 import PeopleTable from "./components/PeopleTable";
+import UserRoleFilter from "./components/UserRoleFilter";
 import UserStatusFilter from "./components/UserStatusFilter";
 
 function Members() {
@@ -39,6 +40,7 @@ function Members() {
   const can = usePolicy(team);
   const query = params.get("query") || undefined;
   const filter = params.get("filter") || undefined;
+  const role = params.get("role") || undefined;
   const sort = params.get("sort") || "name";
   const direction = (params.get("direction") || "asc").toUpperCase() as
     | "ASC"
@@ -58,6 +60,7 @@ function Members() {
           direction,
           query,
           filter,
+          role,
         });
         setTotalPages(Math.ceil(response[PAGINATION_SYMBOL].total / limit));
         setUserIds(response.map((u: User) => u.id));
@@ -67,7 +70,7 @@ function Members() {
     };
 
     void fetchData();
-  }, [query, sort, filter, page, direction, users, users.counts.all]);
+  }, [query, sort, filter, role, page, direction, users, users.counts.all]);
 
   React.useEffect(() => {
     let filtered = users.orderedData;
@@ -76,36 +79,32 @@ function Members() {
       filtered = users.active.filter((u) => userIds.includes(u.id));
     } else if (filter === "all") {
       filtered = users.orderedData.filter((u) => userIds.includes(u.id));
-    } else if (filter === "admins") {
-      filtered = users.admins.filter((u) => userIds.includes(u.id));
-    } else if (filter === "members") {
-      filtered = users.members.filter((u) => userIds.includes(u.id));
     } else if (filter === "suspended") {
       filtered = users.suspended.filter((u) => userIds.includes(u.id));
     } else if (filter === "invited") {
       filtered = users.invited.filter((u) => userIds.includes(u.id));
-    } else if (filter === "viewers") {
+    }
-      filtered = users.viewers.filter((u) => userIds.includes(u.id));
+
+    if (role) {
+      filtered = filtered.filter((u) => u.role === role);
     }
 
     // sort the resulting data by the original order from the server
     setData(sortBy(filtered, (item) => userIds.indexOf(item.id)));
   }, [
     filter,
+    role,
     users.active,
-    users.admins,
-    users.members,
     users.orderedData,
     users.suspended,
     users.invited,
-    users.viewers,
     userIds,
   ]);
 
-  const handleFilter = React.useCallback(
+  const handleStatusFilter = React.useCallback(
-    (filter) => {
+    (f) => {
-      if (filter) {
+      if (f) {
-        params.set("filter", filter);
+        params.set("filter", f);
         params.delete("page");
       } else {
         params.delete("filter");
@@ -119,6 +118,23 @@ function Members() {
     [params, history, location.pathname]
   );
 
+  const handleRoleFilter = React.useCallback(
+    (r) => {
+      if (r) {
+        params.set("role", r);
+        params.delete("page");
+      } else {
+        params.delete("role");
+      }
+
+      history.replace({
+        pathname: location.pathname,
+        search: params.toString(),
+      });
+    },
+    [params, history, location.pathname]
+  );
+
   const handleSearch = React.useCallback(
     (event) => {
       const { value } = event.target;
@@ -182,7 +198,11 @@ function Members() {
         />
         <LargeUserStatusFilter
           activeKey={filter ?? ""}
-          onSelect={handleFilter}
+          onSelect={handleStatusFilter}
+        />
+        <LargeUserRoleFilter
+          activeKey={role ?? ""}
+          onSelect={handleRoleFilter}
         />
       </Flex>
       <PeopleTable
@@ -202,4 +222,8 @@ const LargeUserStatusFilter = styled(UserStatusFilter)`
   height: 32px;
 `;
 
+const LargeUserRoleFilter = styled(UserRoleFilter)`
+  height: 32px;
+`;
+
 export default observer(Members);

app/scenes/Settings/components/UserRoleFilter.tsx

@@ -0,0 +1,50 @@
+import compact from "lodash/compact";
+import { observer } from "mobx-react";
+import * as React from "react";
+import { useTranslation } from "react-i18next";
+import { UserRole } from "@shared/types";
+import FilterOptions from "~/components/FilterOptions";
+
+type Props = {
+  activeKey: string;
+  onSelect: (key: string | null | undefined) => void;
+};
+
+const UserRoleFilter = ({ activeKey, onSelect, ...rest }: Props) => {
+  const { t } = useTranslation();
+
+  const options = React.useMemo(
+    () =>
+      compact([
+        {
+          key: "",
+          label: t("All roles"),
+        },
+        {
+          key: UserRole.Admin,
+          label: t("Admins"),
+        },
+        {
+          key: UserRole.Member,
+          label: t("Editors"),
+        },
+        {
+          key: UserRole.Viewer,
+          label: t("Viewers"),
+        },
+      ]),
+    [t]
+  );
+
+  return (
+    <FilterOptions
+      options={options}
+      selectedKeys={[activeKey]}
+      onSelect={onSelect}
+      defaultLabel={t("All roles")}
+      {...rest}
+    />
+  );
+};
+
+export default observer(UserRoleFilter);

app/scenes/Settings/components/UserStatusFilter.tsx

@@ -17,22 +17,14 @@ const UserStatusFilter = ({ activeKey, onSelect, ...rest }: Props) => {
   const options = React.useMemo(
     () =>
       compact([
+        {
+          key: "all",
+          label: t("All status"),
+        },
         {
           key: "",
           label: t("Active"),
         },
-        {
-          key: "all",
-          label: t("Everyone"),
-        },
-        {
-          key: "members",
-          label: t("Members"),
-        },
-        {
-          key: "admins",
-          label: t("Admins"),
-        },
         ...(user.isAdmin
           ? [
               {
@@ -45,10 +37,6 @@ const UserStatusFilter = ({ activeKey, onSelect, ...rest }: Props) => {
           key: "invited",
           label: t("Invited"),
         },
-        {
-          key: "viewers",
-          label: t("Viewers"),
-        },
       ]),
     [t, user.isAdmin]
   );

shared/i18n/locales/en_US/translation.json

@@ -806,8 +806,10 @@
   "Date shared": "Date shared",
   "Domain": "Domain",
   "Views": "Views",
-  "Everyone": "Everyone",
+  "All roles": "All roles",
   "Admins": "Admins",
+  "Editors": "Editors",
+  "All status": "All status",
   "Settings saved": "Settings saved",
   "Logo updated": "Logo updated",
   "Unable to upload new logo": "Unable to upload new logo",