yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Improve perf of server tests (#5785)

Browse Source
This commit is contained in:
Tom Moor
2023-09-06 07:14:49 -04:00
committed by GitHub
parent a724a21c21
commit 3eb947e9a5
69 changed files with 2045 additions and 1551 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
server/models/Collection.test.ts
View File

@@ -7,7 +7,7 @@ import {
buildTeam,
buildDocument,
} from "@server/test/factories";
import { setupTestDatabase, seed } from "@server/test/support";
import { setupTestDatabase } from "@server/test/support";
import slugify from "@server/utils/slugify";
import Collection from "./Collection";
import Document from "./Document";
@@ -103,7 +103,7 @@ describe("getDocumentTree", () => {
describe("#addDocumentToStructure", () => {
test("should add as last element without index", async () => {
const { collection } = await seed();
const collection = await buildCollection();
const id = uuidv4();
const newDocument = await buildDocument({
id,
@@ -112,12 +112,12 @@ describe("#addDocumentToStructure", () => {
teamId: collection.teamId,
});
await collection.addDocumentToStructure(newDocument);
expect(collection.documentStructure!.length).toBe(2);
expect(collection.documentStructure![1].id).toBe(id);
expect(collection.documentStructure!.length).toBe(1);
expect(collection.documentStructure![0].id).toBe(id);
});
test("should add with an index", async () => {
const { collection } = await seed();
const collection = await buildCollection();
const id = uuidv4();
const newDocument = await buildDocument({
id,
@@ -126,12 +126,15 @@ describe("#addDocumentToStructure", () => {
teamId: collection.teamId,
});
await collection.addDocumentToStructure(newDocument, 1);
expect(collection.documentStructure!.length).toBe(2);
expect(collection.documentStructure![1].id).toBe(id);
expect(collection.documentStructure!.length).toBe(1);
expect(collection.documentStructure![0].id).toBe(id);
});
test("should add as a child if with parent", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
const id = uuidv4();
const newDocument = await buildDocument({
id,
@@ -147,7 +150,10 @@ describe("#addDocumentToStructure", () => {
});
test("should add as a child if with parent with index", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
const newDocument = await buildDocument({
id: uuidv4(),
title: "node",
@@ -170,7 +176,7 @@ describe("#addDocumentToStructure", () => {
});
describe("options: documentJson", () => {
test("should append supplied json over document's own", async () => {
const { collection } = await seed();
const collection = await buildCollection();
const id = uuidv4();
const newDocument = await buildDocument({
id: uuidv4(),
@@ -193,15 +199,18 @@ describe("#addDocumentToStructure", () => {
],
},
});
expect(collection.documentStructure![1].children.length).toBe(1);
expect(collection.documentStructure![1].children[0].id).toBe(id);
expect(collection.documentStructure![0].children.length).toBe(1);
expect(collection.documentStructure![0].children[0].id).toBe(id);
});
});
});
describe("#updateDocument", () => {
test("should update root document's data", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
document.title = "Updated title";
await document.save();
await collection.updateDocument(document);
@@ -209,7 +218,10 @@ describe("#updateDocument", () => {
});
test("should update child document's data", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
const newDocument = await Document.create({
parentDocumentId: document.id,
collectionId: collection.id,
@@ -233,14 +245,20 @@ describe("#updateDocument", () => {
describe("#removeDocument", () => {
test("should save if removing", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
jest.spyOn(collection, "save");
await collection.deleteDocument(document);
expect(collection.save).toBeCalled();
});
test("should remove documents from root", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
await collection.deleteDocument(document);
expect(collection.documentStructure!.length).toBe(0);
// Verify that the document was removed
@@ -253,7 +271,10 @@ describe("#removeDocument", () => {
});
test("should remove a document with child documents", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
// Add a child for testing
const newDocument = await Document.create({
parentDocumentId: document.id,
@@ -279,7 +300,10 @@ describe("#removeDocument", () => {
});
test("should remove a child document", async () => {
const { collection, document } = await seed();
const collection = await buildCollection();
const document = await buildDocument({ collectionId: collection.id });
await collection.reload();
// Add a child for testing
const newDocument = await Document.create({
parentDocumentId: document.id,