chore: Refactor backlinks and revisions (#1611)

* Update backlinks service to not rely on revisions

* fix: Add missing index for finding backlinks

* Debounce revision creation (#1616)

* refactor debounce logic to service

* Debounce slack notification

* Revisions created by service

* fix: Revision sidebar latest

* test: Add tests for notifications

server/services/backlinks.test.js

@@ -1,5 +1,5 @@
 /* eslint-disable flowtype/require-valid-file-annotation */
-import Backlink from "../models/Backlink";
+import { Backlink } from "../models";
 import { buildDocument } from "../test/factories";
 import { flushdb } from "../test/support";
 import BacklinksService from "./backlinks";
@@ -22,7 +22,6 @@ describe("documents.update", () => {
       collectionId: document.collectionId,
       teamId: document.teamId,
       actorId: document.createdById,
-      data: { autosave: false },
     });
 
     const backlinks = await Backlink.findAll({
@@ -48,7 +47,6 @@ describe("documents.update", () => {
       collectionId: document.collectionId,
       teamId: document.teamId,
       actorId: document.createdById,
-      data: { autosave: false },
     });
 
     const backlinks = await Backlink.findAll({
@@ -71,7 +69,6 @@ describe("documents.update", () => {
       collectionId: document.collectionId,
       teamId: document.teamId,
       actorId: document.createdById,
-      data: { autosave: false },
     });
 
     const backlinks = await Backlink.findAll({
@@ -83,8 +80,11 @@ describe("documents.update", () => {
 
   test("should destroy removed backlink records", async () => {
     const otherDocument = await buildDocument();
+    const yetAnotherDocument = await buildDocument();
     const document = await buildDocument({
-      text: `[this is a link](${otherDocument.url})`,
+      text: `[this is a link](${otherDocument.url})
+
+[this is a another link](${yetAnotherDocument.url})`,
     });
 
     await Backlinks.on({
@@ -93,10 +93,11 @@ describe("documents.update", () => {
       collectionId: document.collectionId,
       teamId: document.teamId,
       actorId: document.createdById,
-      data: { autosave: false },
     });
 
-    document.text = "Link is gone";
+    document.text = `First link is gone
+    
+[this is a another link](${yetAnotherDocument.url})`;
     await document.save();
 
     await Backlinks.on({
@@ -105,7 +106,39 @@ describe("documents.update", () => {
       collectionId: document.collectionId,
       teamId: document.teamId,
       actorId: document.createdById,
-      data: { autosave: false },
+    });
+
+    const backlinks = await Backlink.findAll({
+      where: { reverseDocumentId: document.id },
+    });
+
+    expect(backlinks.length).toBe(1);
+    expect(backlinks[0].documentId).toBe(yetAnotherDocument.id);
+  });
+});
+
+describe("documents.delete", () => {
+  test("should destroy related backlinks", async () => {
+    const otherDocument = await buildDocument();
+    const document = await buildDocument();
+
+    document.text = `[this is a link](${otherDocument.url})`;
+    await document.save();
+
+    await Backlinks.on({
+      name: "documents.update",
+      documentId: document.id,
+      collectionId: document.collectionId,
+      teamId: document.teamId,
+      actorId: document.createdById,
+    });
+
+    await Backlinks.on({
+      name: "documents.delete",
+      documentId: document.id,
+      collectionId: document.collectionId,
+      teamId: document.teamId,
+      actorId: document.createdById,
     });
 
     const backlinks = await Backlink.findAll({
@@ -114,11 +147,14 @@ describe("documents.update", () => {
 
     expect(backlinks.length).toBe(0);
   });
+});
 
+describe("documents.title_change", () => {
   test("should update titles in backlinked documents", async () => {
     const newTitle = "test";
     const document = await buildDocument();
     const otherDocument = await buildDocument();
+    const previousTitle = otherDocument.title;
 
     // create a doc with a link back
     document.text = `[${otherDocument.title}](${otherDocument.url})`;
@@ -131,7 +167,6 @@ describe("documents.update", () => {
       collectionId: document.collectionId,
       teamId: document.teamId,
       actorId: document.createdById,
-      data: { autosave: false },
     });
 
     // change the title of the linked doc
@@ -140,12 +175,15 @@ describe("documents.update", () => {
 
     // does the text get updated with the new title
     await Backlinks.on({
-      name: "documents.update",
+      name: "documents.title_change",
       documentId: otherDocument.id,
       collectionId: otherDocument.collectionId,
       teamId: otherDocument.teamId,
       actorId: otherDocument.createdById,
-      data: { autosave: false },
+      data: {
+        previousTitle,
+        title: newTitle,
+      },
     });
     await document.reload();