yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Improve multi-partial word matching in search

Browse Source
This commit is contained in:
Tom Moor
2024-02-02 08:58:51 -05:00
parent 490a1b6009
commit 391814a54e
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/models/helpers/SearchHelper.ts
View File

@@ -416,12 +416,8 @@ export default class SearchHelper {
// limit length of search queries as we're using regex against untrusted input // limit length of search queries as we're using regex against untrusted input
let limitedQuery = this.escapeQuery(query.slice(0, this.maxQueryLength)); let limitedQuery = this.escapeQuery(query.slice(0, this.maxQueryLength));
// if the search term is one unquoted word then allow partial matches automatically const quotedSearch =
const queryWordCount = limitedQuery.split(" ").length; limitedQuery.startsWith('"') && limitedQuery.endsWith('"');
const singleUnquotedSearch =
queryWordCount === 1 &&
!limitedQuery.startsWith('"') &&
!limitedQuery.endsWith('"');
// Replace single quote characters with &. // Replace single quote characters with &.
const singleQuotes = limitedQuery.matchAll(/'+/g); const singleQuotes = limitedQuery.matchAll(/'+/g);
@@ -440,7 +436,7 @@ export default class SearchHelper {
} }
return ( return (
queryParser()(singleUnquotedSearch ? `${limitedQuery}*` : limitedQuery) queryParser()(quotedSearch ? limitedQuery : `${limitedQuery}*`)
// Remove any trailing join characters // Remove any trailing join characters
.replace(/&$/, "") .replace(/&$/, "")
); );