Centralize default user and team preferences. (#5172

Passing the fallback at each callpoint was dumb
This commit is contained in:
Tom Moor
2023-04-09 17:23:58 -04:00
committed by GitHub
parent 8324b03938
commit 2f9a56aa6f
11 changed files with 67 additions and 39 deletions

View File

@@ -87,29 +87,29 @@ function Preferences() {
/>
</SettingRow>
<SettingRow
name="useCursorPointer"
name={UserPreference.UseCursorPointer}
label={t("Use pointer cursor")}
description={t(
"Show a hand cursor when hovering over interactive elements."
)}
>
<Switch
id="useCursorPointer"
name="useCursorPointer"
checked={user.getPreference(UserPreference.UseCursorPointer, true)}
id={UserPreference.UseCursorPointer}
name={UserPreference.UseCursorPointer}
checked={user.getPreference(UserPreference.UseCursorPointer)}
onChange={handlePreferenceChange}
/>
</SettingRow>
<SettingRow
name="codeBlockLineNumbers"
name={UserPreference.CodeBlockLineNumers}
label={t("Show line numbers")}
description={t("Show line numbers on code blocks in documents.")}
border={false}
>
<Switch
id="codeBlockLineNumbers"
name="codeBlockLineNumbers"
checked={user.getPreference(UserPreference.CodeBlockLineNumers, true)}
id={UserPreference.CodeBlockLineNumers}
name={UserPreference.CodeBlockLineNumers}
checked={user.getPreference(UserPreference.CodeBlockLineNumers)}
onChange={handlePreferenceChange}
/>
</SettingRow>
@@ -117,16 +117,16 @@ function Preferences() {
<Heading as="h2">{t("Behavior")}</Heading>
<SettingRow
border={false}
name="rememberLastPath"
name={UserPreference.RememberLastPath}
label={t("Remember previous location")}
description={t(
"Automatically return to the document you were last viewing when the app is re-opened."
)}
>
<Switch
id="rememberLastPath"
name="rememberLastPath"
checked={!!user.preferences?.rememberLastPath}
id={UserPreference.RememberLastPath}
name={UserPreference.RememberLastPath}
checked={!!user.getPreference(UserPreference.RememberLastPath)}
onChange={handlePreferenceChange}
/>
</SettingRow>