fix: Menus with accessory in-front of label cannot be navigated with keyboard letters

fix: Flash of outline state when focusing menu item with keyboard
2024-04-11 20:51:56 -04:00
parent 9c179fdd30
commit 2e427a1e83
4 changed files with 13 additions and 6 deletions
--- a/app/components/ContextMenu/MenuItem.tsx
+++ b/app/components/ContextMenu/MenuItem.tsx
@@ -71,12 +71,11 @@ const MenuItem = (
          ])}
        >
          {selected !== undefined && (
-            <>
+            <MenuIconWrapper aria-hidden>
              {selected ? <CheckmarkIcon /> : <Spacer />}
-              &nbsp;
-            </>
+            </MenuIconWrapper>
          )}
-          {icon && <MenuIconWrapper>{icon}</MenuIconWrapper>}
+          {icon && <MenuIconWrapper aria-hidden>{icon}</MenuIconWrapper>}
          {children}
        </MenuAnchor>
      );