yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Self-hosted should show signin options for all configured authentication methods (#2986)

Browse Source
This commit is contained in:
Tom Moor
2022-06-04 10:46:03 -07:00
committed by GitHub
parent 4eb3b61c7a
commit 28439d315d
6 changed files with 205 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
server/routes/api/auth.test.ts
View File

@@ -1,4 +1,5 @@
import TestServer from "fetch-test-server";
import sharedEnv from "@shared/env";
import env from "@server/env";
import webService from "@server/services/web";
import { buildUser, buildTeam } from "@server/test/factories";
@@ -49,6 +50,8 @@ describe("#auth.info", () => {
describe("#auth.config", () => {
it("should return available SSO providers", async () => {
env.DEPLOYMENT = "hosted";
const res = await server.post("/api/auth.config");
const body = await res.json();
expect(res.status).toEqual(200);
@@ -58,7 +61,10 @@ describe("#auth.config", () => {
});
it("should return available providers for team subdomain", async () => {
env.URL = "http://localoutline.com";
env.URL = sharedEnv.URL = "http://localoutline.com";
env.SUBDOMAINS_ENABLED = sharedEnv.SUBDOMAINS_ENABLED = true;
env.DEPLOYMENT = "hosted";
await buildTeam({
guestSignin: false,
subdomain: "example",
@@ -81,6 +87,8 @@ describe("#auth.config", () => {
});
it("should return available providers for team custom domain", async () => {
env.DEPLOYMENT = "hosted";
await buildTeam({
guestSignin: false,
domain: "docs.mycompany.com",
@@ -103,7 +111,9 @@ describe("#auth.config", () => {
});
it("should return email provider for team when guest signin enabled", async () => {
env.URL = "http://localoutline.com";
env.URL = sharedEnv.URL = "http://localoutline.com";
env.DEPLOYMENT = "hosted";
await buildTeam({
guestSignin: true,
subdomain: "example",
@@ -127,7 +137,9 @@ describe("#auth.config", () => {
});
it("should not return provider when disabled", async () => {
env.URL = "http://localoutline.com";
env.URL = sharedEnv.URL = "http://localoutline.com";
env.DEPLOYMENT = "hosted";
await buildTeam({
guestSignin: false,
subdomain: "example",
@@ -148,8 +160,9 @@ describe("#auth.config", () => {
expect(res.status).toEqual(200);
expect(body.data.providers.length).toBe(0);
});
describe("self hosted", () => {
it("should return available providers for team", async () => {
it("should return all configured providers but respect email setting", async () => {
env.DEPLOYMENT = "";
await buildTeam({
guestSignin: false,
@@ -163,9 +176,11 @@ describe("#auth.config", () => {
const res = await server.post("/api/auth.config");
const body = await res.json();
expect(res.status).toEqual(200);
expect(body.data.providers.length).toBe(1);
expect(body.data.providers[0].name).toBe("Slack");
expect(body.data.providers.length).toBe(2);
expect(body.data.providers[0].name).toBe("Google");
expect(body.data.providers[1].name).toBe("Slack");
});
it("should return email provider for team when guest signin enabled", async () => {
env.DEPLOYMENT = "";
await buildTeam({
@@ -180,9 +195,10 @@ describe("#auth.config", () => {
const res = await server.post("/api/auth.config");
const body = await res.json();
expect(res.status).toEqual(200);
expect(body.data.providers.length).toBe(2);
expect(body.data.providers.length).toBe(3);
expect(body.data.providers[0].name).toBe("Slack");
expect(body.data.providers[1].name).toBe("Email");
expect(body.data.providers[1].name).toBe("Google");
expect(body.data.providers[2].name).toBe("Email");
});
});
});