yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Change response of shares.info response for unshared document (#1666)

Browse Source 
* Update server/api/share.js to send 204 status for unshared documents.

* Update shares.info endpoint to expect 204 in a few test.

* Update SharesStore and ApiClient to handle 204 status code
This commit is contained in:
Saumya Pandey
2020-12-01 12:19:15 +05:30
committed by GitHub
parent 183f06c2d1
commit 283b479689
4 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/api/shares.js
View File

@@ -30,7 +30,7 @@ router.post("shares.info", auth(), async (ctx) => {
},
});
if (!share || !share.document) {
throw new NotFoundError();
return (ctx.response.status = 204);
}
authorize(user, "read", share);

6
server/api/shares.test.js
View File

@@ -281,7 +281,7 @@ describe("#shares.info", () => {
const res = await server.post("/api/shares.info", {
body: { token: user.getJwtToken(), documentId: document.id },
});
expect(res.status).toEqual(404);
expect(res.status).toEqual(204);
});
it("should not find revoked share", async () => {
@@ -295,7 +295,7 @@ describe("#shares.info", () => {
const res = await server.post("/api/shares.info", {
body: { token: user.getJwtToken(), documentId: document.id },
});
expect(res.status).toEqual(404);
expect(res.status).toEqual(204);
});
it("should not find share for deleted document", async () => {
@@ -309,7 +309,7 @@ describe("#shares.info", () => {
const res = await server.post("/api/shares.info", {
body: { token: user.getJwtToken(), documentId: document.id },
});
expect(res.status).toEqual(404);
expect(res.status).toEqual(204);
});
it("should require authentication", async () => {