perf: Move collection sorting to frontend (#3475)

* perf: Move collection sorting to frontend, on demand, memoized * fix: Add default
2022-05-01 08:30:16 -07:00
parent 5cd4ecd34a
commit 25dce04046
9 changed files with 85 additions and 59 deletions
--- a/app/components/Sidebar/components/DocumentLink.tsx
+++ b/app/components/Sidebar/components/DocumentLink.tsx
@@ -258,19 +258,18 @@ function InnerDocumentLink(
  });

  const nodeChildren = React.useMemo(() => {
-    if (
-      collection &&
+    const insertDraftDocument =
      activeDocument?.isDraft &&
      activeDocument?.isActive &&
-      activeDocument?.parentDocumentId === node.id
-    ) {
-      return sortNavigationNodes(
-        [activeDocument?.asNavigationNode, ...node.children],
-        collection.sort
-      );
-    }
+      activeDocument?.parentDocumentId === node.id;

-    return node.children;
+    return collection && insertDraftDocument
+      ? sortNavigationNodes(
+          [activeDocument?.asNavigationNode, ...node.children],
+          collection.sort,
+          false
+        )
+      : node.children;
  }, [
    activeDocument?.isActive,
    activeDocument?.isDraft,