From 21bb8d36ae95fa8dc4efe225c9b7ae8544467840 Mon Sep 17 00:00:00 2001
From: Tom Moor <tom.moor@gmail.com>
Date: Sat, 3 Feb 2024 14:59:17 -0500
Subject: [PATCH] Hide permissions on collection edit for now

---
 app/components/Collection/CollectionForm.tsx | 38 +++++++++++---------
 shared/i18n/locales/en_US/translation.json   | 30 ++++++++--------
 2 files changed, 36 insertions(+), 32 deletions(-)

diff --git a/app/components/Collection/CollectionForm.tsx b/app/components/Collection/CollectionForm.tsx
index aa0a8e4c2..93e16485f 100644
--- a/app/components/Collection/CollectionForm.tsx
+++ b/app/components/Collection/CollectionForm.tsx
@@ -112,24 +112,28 @@ export const CollectionForm = observer(function CollectionForm_({
           flex
         />
       </Flex>
-      <Controller
-        control={control}
-        name="permission"
-        render={({ field }) => (
-          <InputSelectPermission
-            ref={field.ref}
-            value={field.value}
-            onChange={(value: CollectionPermission) => {
-              field.onChange(value);
-            }}
-            note={t(
-              "The default access for workspace members, you can share with more users or groups later."
-            )}
-          />
-        )}
-      />
 
-      {team.sharing && (
+      {/* Following controls are available in create flow, but moved elsewhere for edit */}
+      {!collection && (
+        <Controller
+          control={control}
+          name="permission"
+          render={({ field }) => (
+            <InputSelectPermission
+              ref={field.ref}
+              value={field.value}
+              onChange={(value: CollectionPermission) => {
+                field.onChange(value);
+              }}
+              note={t(
+                "The default access for workspace members, you can share with more users or groups later."
+              )}
+            />
+          )}
+        />
+      )}
+
+      {team.sharing && !collection && (
         <Switch
           id="sharing"
           label={t("Public document sharing")}
diff --git a/shared/i18n/locales/en_US/translation.json b/shared/i18n/locales/en_US/translation.json
index 621fafd22..13fc0082c 100644
--- a/shared/i18n/locales/en_US/translation.json
+++ b/shared/i18n/locales/en_US/translation.json
@@ -236,6 +236,21 @@
   "Editor": "Editor",
   "Viewer": "Viewer",
   "Admin": "Admin",
+  "We sent out your invites!": "We sent out your invites!",
+  "Those email addresses are already invited": "Those email addresses are already invited",
+  "Sorry, you can only send {{MAX_INVITES}} invites at a time": "Sorry, you can only send {{MAX_INVITES}} invites at a time",
+  "Share link copied": "Share link copied",
+  "Invited members will receive access to": "Invited members will receive access to",
+  "{{collectionCount}} collections": "{{collectionCount}} collections",
+  "Invite members or guests to join your workspace. They can sign in with {{signinMethods}} or use their email address.": "Invite members or guests to join your workspace. They can sign in with {{signinMethods}} or use their email address.",
+  "Invite members to join your workspace. They will need to sign in with {{signinMethods}}.": "Invite members to join your workspace. They will need to sign in with {{signinMethods}}.",
+  "As an admin you can also <2>enable email sign-in</2>.": "As an admin you can also <2>enable email sign-in</2>.",
+  "Want a link to share directly with your team?": "Want a link to share directly with your team?",
+  "Email": "Email",
+  "Remove invite": "Remove invite",
+  "Add another": "Add another",
+  "Inviting": "Inviting",
+  "Send Invites": "Send Invites",
   "{{appName}} is available in your language {{optionLabel}}, would you like to change?": "{{appName}} is available in your language {{optionLabel}}, would you like to change?",
   "Change Language": "Change Language",
   "Dismiss": "Dismiss",
@@ -440,7 +455,6 @@
   "New template": "New template",
   "Revision options": "Revision options",
   "Share link revoked": "Share link revoked",
-  "Share link copied": "Share link copied",
   "Share options": "Share options",
   "Go to document": "Go to document",
   "Revoke link": "Revoke link",
@@ -647,20 +661,6 @@
   "Weird, this shouldn’t ever be empty": "Weird, this shouldn’t ever be empty",
   "You haven’t created any documents yet": "You haven’t created any documents yet",
   "Documents you’ve recently viewed will be here for easy access": "Documents you’ve recently viewed will be here for easy access",
-  "We sent out your invites!": "We sent out your invites!",
-  "Those email addresses are already invited": "Those email addresses are already invited",
-  "Sorry, you can only send {{MAX_INVITES}} invites at a time": "Sorry, you can only send {{MAX_INVITES}} invites at a time",
-  "Invited members will receive access to": "Invited members will receive access to",
-  "{{collectionCount}} collections": "{{collectionCount}} collections",
-  "Invite members or guests to join your workspace. They can sign in with {{signinMethods}} or use their email address.": "Invite members or guests to join your workspace. They can sign in with {{signinMethods}} or use their email address.",
-  "Invite members to join your workspace. They will need to sign in with {{signinMethods}}.": "Invite members to join your workspace. They will need to sign in with {{signinMethods}}.",
-  "As an admin you can also <2>enable email sign-in</2>.": "As an admin you can also <2>enable email sign-in</2>.",
-  "Want a link to share directly with your team?": "Want a link to share directly with your team?",
-  "Email": "Email",
-  "Remove invite": "Remove invite",
-  "Add another": "Add another",
-  "Inviting": "Inviting",
-  "Send Invites": "Send Invites",
   "Open command menu": "Open command menu",
   "Edit current document": "Edit current document",
   "Move current document": "Move current document",