yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Uploaded and immediately deleted images are not removed from storage (#4562)

Browse Source 
* fix: Uploaded and immediately deleted images are not removed from storage upon permanant delete
closes #4557

* Move attachment deletion async
This commit is contained in:
Tom Moor
2022-12-11 08:29:38 -08:00
committed by GitHub
parent 7e22526cc7
commit 0f19c550f9
5 changed files with 59 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
server/commands/documentPermanentDeleter.test.ts
View File

@@ -1,9 +1,12 @@
import { subDays } from "date-fns";
import { Attachment, Document } from "@server/models";
import DeleteAttachmentTask from "@server/queues/tasks/DeleteAttachmentTask";
import { buildAttachment, buildDocument } from "@server/test/factories";
import { setupTestDatabase } from "@server/test/support";
import documentPermanentDeleter from "./documentPermanentDeleter";
jest.mock("@server/queues/tasks/DeleteAttachmentTask");
setupTestDatabase();
describe("documentPermanentDeleter", () => {
@@ -47,11 +50,15 @@ describe("documentPermanentDeleter", () => {
teamId: document.teamId,
documentId: document.id,
});
await buildAttachment({
teamId: document.teamId,
documentId: document.id,
});
document.text = `![text](${attachment.redirectUrl})`;
await document.save();
const countDeletedDoc = await documentPermanentDeleter([document]);
expect(countDeletedDoc).toEqual(1);
expect(await Attachment.count()).toEqual(0);
expect(DeleteAttachmentTask.schedule).toHaveBeenCalledTimes(2);
expect(
await Document.unscoped().count({
paranoid: false,