fix: Allow searching of previous document titles (#2326)

* Add migrations

* Handle previousTitles when titles is updated

* Add necessary test cases

* Use previous title while searching

* Rewrite logic to update previousTitles in beforeSave hook

* Update weights

* Update test to match new rank order

* Add tooltip to inform user on document

* Add code comment

* Remove previous title tooltip

* fix: Remove unused string, add model tests

Co-authored-by: Tom Moor <tom.moor@gmail.com>

server/models/Document.test.js

@@ -221,6 +221,41 @@ describe("#searchForTeam", () => {
     const { totalCount } = await Document.searchForTeam(team, "test");
     expect(totalCount).toBe("2");
   });
+
+  test("should return the document when searched with their previous titles", async () => {
+    const team = await buildTeam();
+    const collection = await buildCollection({ teamId: team.id });
+    const document = await buildDocument({
+      teamId: team.id,
+      collectionId: collection.id,
+      title: "test number 1",
+    });
+
+    document.title = "change";
+    await document.save();
+
+    const { totalCount } = await Document.searchForTeam(team, "test number");
+    expect(totalCount).toBe("1");
+  });
+
+  test("should not return the document when searched with neither the titles nor the previous titles", async () => {
+    const team = await buildTeam();
+    const collection = await buildCollection({ teamId: team.id });
+    const document = await buildDocument({
+      teamId: team.id,
+      collectionId: collection.id,
+      title: "test number 1",
+    });
+
+    document.title = "change";
+    await document.save();
+
+    const { totalCount } = await Document.searchForTeam(
+      team,
+      "title doesn't exist"
+    );
+    expect(totalCount).toBe("0");
+  });
 });
 
 describe("#searchForUser", () => {
@@ -273,6 +308,51 @@ describe("#searchForUser", () => {
     const { totalCount } = await Document.searchForUser(user, "test");
     expect(totalCount).toBe("2");
   });
+
+  test("should return the document when searched with their previous titles", async () => {
+    const team = await buildTeam();
+    const user = await buildUser({ teamId: team.id });
+    const collection = await buildCollection({
+      teamId: team.id,
+      userId: user.id,
+    });
+    const document = await buildDocument({
+      teamId: team.id,
+      userId: user.id,
+      collectionId: collection.id,
+      title: "test number 1",
+    });
+
+    document.title = "change";
+    await document.save();
+
+    const { totalCount } = await Document.searchForUser(user, "test number");
+    expect(totalCount).toBe("1");
+  });
+
+  test("should not return the document when searched with neither the titles nor the previous titles", async () => {
+    const team = await buildTeam();
+    const user = await buildUser({ teamId: team.id });
+    const collection = await buildCollection({
+      teamId: team.id,
+      userId: user.id,
+    });
+    const document = await buildDocument({
+      teamId: team.id,
+      userId: user.id,
+      collectionId: collection.id,
+      title: "test number 1",
+    });
+
+    document.title = "change";
+    await document.save();
+
+    const { totalCount } = await Document.searchForUser(
+      user,
+      "title doesn't exist"
+    );
+    expect(totalCount).toBe("0");
+  });
 });
 
 describe("#delete", () => {
@@ -309,6 +389,37 @@ describe("#delete", () => {
   });
 });
 
+describe("#save", () => {
+  test("should have empty previousTitles by default", async () => {
+    const document = await buildDocument();
+    expect(document.previousTitles).toBe(null);
+  });
+
+  test("should include previousTitles on save", async () => {
+    const document = await buildDocument();
+
+    document.title = "test";
+    await document.save();
+
+    expect(document.previousTitles.length).toBe(1);
+  });
+
+  test("should not duplicate previousTitles", async () => {
+    const document = await buildDocument();
+
+    document.title = "test";
+    await document.save();
+
+    document.title = "example";
+    await document.save();
+
+    document.title = "test";
+    await document.save();
+
+    expect(document.previousTitles.length).toBe(3);
+  });
+});
+
 describe("#findByPk", () => {
   test("should return document when urlId is correct", async () => {
     const { document } = await seed();