From 098d91808b4615c28526ade3605a162fbc95e95d Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Sat, 8 Jul 2023 15:02:44 -0400 Subject: [PATCH] fix: Selection passed to setSelection must point at the current document, triple clicking caption --- shared/editor/nodes/SimpleImage.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shared/editor/nodes/SimpleImage.tsx b/shared/editor/nodes/SimpleImage.tsx index f0748daa3..c47460079 100644 --- a/shared/editor/nodes/SimpleImage.tsx +++ b/shared/editor/nodes/SimpleImage.tsx @@ -136,9 +136,11 @@ export default class SimpleImage extends Node { }; handleMouseDown = (ev: React.MouseEvent) => { + // always prevent clicks in caption from bubbling to the editor + ev.stopPropagation(); + if (document.activeElement !== ev.currentTarget) { ev.preventDefault(); - ev.stopPropagation(); ev.currentTarget.focus(); } };