yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: change the way that share permissions are checked on child documents to use the parentId field of documents rather than the collection structure (#3294)

Browse Source
This commit is contained in:
Nan Yu
2022-03-28 10:18:59 -07:00
committed by GitHub
parent 3d478246bf
commit 096b35e08e
3 changed files with 6 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/routes/api/documents.ts
View File

@@ -542,10 +542,12 @@ async function loadDocument({
// shared then includeChildDocuments must be enabled and the document must
// still be nested within the shared document
if (share.document.id !== document.id) {
if (
!share.includeChildDocuments ||
!collection.isChildDocument(share.document.id, document.id)
) {
if (!share.includeChildDocuments) {
throw AuthorizationError();
}
const childDocumentIds = await share.document.getChildDocumentIds();
if (!childDocumentIds.includes(document.id)) {
throw AuthorizationError();
}
}